Put modules before libraries in Intellij iml files #1846
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes dependency priority for GenIdea command.
Problem description:
When multiple dependencies have a class with the same name, Mill takes first one from the classpath, as well as Intellij takes first one from the iml file. If some dependencies are modules, Mill put them higher in the classpath, so module classes always take precedence over libraries. But GenIdea put modules after the libraries and therefore Intellij resolves different than Mill class versions. Example of generated iml file:
Fix description:
I swapped libraries and modules in the iml file, so result file looks like:
To prove that this order is correct, I generated iml files for the same project with SBT and Mill BSP, both of them put modules before libraries.