Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented parsing of ROOM_DATA_BYTES #228

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

BG-FraserConnolly
Copy link
Contributor

Unity clients can now receive data sent from the server using client.sendBytes.

For a Unity client to register a call back for a message sent to it by the server using SendBytes, call RoomController OnMessage with the type byte[ ]

Unity clients can now receive data sent from the server using client.sendBytes.
@endel endel merged commit e3765b7 into colyseus:master Jul 3, 2024
@endel
Copy link
Member

endel commented Jul 3, 2024

Thank you for the PR @BG-FraserConnolly 💜

@BG-FraserConnolly
Copy link
Contributor Author

Thanks for the quick approval @endel but I'm afraid I made a small mistake.

line 506 should be:
else if (code == ColyseusProtocol.ROOM_DATA || code == ColyseusProtocol.ROOM_DATA_BYTES)

I missed out the second code == when copying from my project to the pull request.

Do you want me to make a new pull request? Should this one be reverted?

@endel
Copy link
Member

endel commented Jul 3, 2024

Hi @BG-FraserConnolly, can you send another PR please? That was an oversight from me as well

@BG-FraserConnolly
Copy link
Contributor Author

@endel, Okay, I've submitted #229

endel pushed a commit that referenced this pull request Jul 3, 2024
* Implemented parsing of ROOM_DATA_BYTES

Unity clients can now receive data sent from the server using client.sendBytes.

* Corrected a logic error
@endel
Copy link
Member

endel commented Jul 3, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants