Make color space optional in getAll()
+ colorSpace.equals()
improvements
#413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
colorSpace.equals()
(and adds JSDoc for the method)getAll()
.Not only does this make
getAll()
more consistent with the rest of the API, it also sets the stage for option 3 here: Precision lets scientific notation leak for small values #388 (comment) . As a side effect, it also implements a performance improvement when the color passed happens to be in the same color space as the one specified as it now goes through the same code path.