-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[types] Re-export some types at the top level #327
[types] Re-export some types at the top level #327
Conversation
Re-exports some potentially desirable types at the top level instead of requiring them to be manually imported from their individual files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few additional suggestions and one typo, otherwise looks good!
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
I should be able to update the import tests in a few hours for the new exports since I don’t have access to an IDE right now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated tests, in case that's helpful.
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Closes #326
Re-exports some potentially desirable types at the top level instead of requiring them to be manually imported from their individual files.
I basically just went through the files in
types/src
and addedexport
s in the mainindex.d.ts
file for types and interfaces that might be wanted.LMK if there are any other types that I missed 😊