Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oklab matrix is not 64bit accurate #356

Closed
svgeesus opened this issue Nov 22, 2023 · 2 comments · Fixed by #357
Closed

Oklab matrix is not 64bit accurate #356

svgeesus opened this issue Nov 22, 2023 · 2 comments · Fixed by #357

Comments

@svgeesus
Copy link
Member

Issue forked from this discussion, @facelessuser wrote:

the current Oklab matrix is not exact enough to give a decent white and will introduce a notable error

recalculating Oklab with 64 bit precision eliminate the inaccuracies near achromatic values

@facelessuser
Copy link
Collaborator

Since it appears you are open to a 64 bit matrix, I can issue a pull request. I'll provide the work I used to calculate them as well. The work may not be in JS as the libraries I've been playing with over the last number of days have frustrated me, but in time, I imagine someone can get it all in a JS solution.

@svgeesus
Copy link
Member Author

Since it appears you are open to a 64 bit matrix, I can issue a pull request. I'll provide the work I used to calculate them as well. The work may not be in JS as the libraries I've been playing with over the last number of days have frustrated me, but in time, I imagine someone can get it all in a JS solution.

The main thing is to know where the values came from. Whether that derivation was in JS, Python, MatLab, Rust does not particularly matter. Thanks for the clear documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants