Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extrald flags for arch #55

Merged
merged 2 commits into from
Apr 28, 2024
Merged

extrald flags for arch #55

merged 2 commits into from
Apr 28, 2024

Conversation

collinalexbell
Copy link
Owner

No description provided.

@collinalexbell
Copy link
Owner Author

Thanks @Rafi1018 #48

@collinalexbell collinalexbell merged commit 4f7723f into master Apr 28, 2024
@collinalexbell collinalexbell deleted the fix-arch branch April 28, 2024 21:57
@Rafi1018
Copy link
Contributor

Thanks @Rafi1018 #48

No problem. But I think this approach will be much better as some distros might remove arch from there as well while it checks if there is pacman or not so much better compatibility :

# Detect if the distro is arch based
HAS_PACMAN := $(shell command -v pacman >/dev/null 2>&1 && echo 1 || echo 0)

# Set extra linker flags for Arch based distros
ifeq ($(HAS_PACMAN),1)
    EXTRA_LDFLAGS := -labsl_log_internal_check_op -labsl_log_internal_message
endif

Tested & it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants