-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Rails 7 #460
Add support for Rails 7 #460
Conversation
+1 Please! |
+1 |
As a temporary solution you can add this to your Gemfile: gem "awesome_nested_set", github: "peterberkenbosch/awesome_nested_set", branch: "rails-7-support" |
Looking at fixing the failing specs around ruby versions:
|
@peterberkenbosch perhaps we can address different versions like this one so the library itself isn't coupled to what Rails 7 supports thanks for looking at this |
Hey @parndt. Good find.. on it! Thanks. |
@peterberkenbosch I've finished getting the tests passing and opened a PR to this branch on your repository. @parndt as part of that change, I had to drop the combustion gem. The older version currently required by awesome_nested_set doesn't work with rails 7. I initially tried updating combustion, but the API has changed and you can no longer pass in the database config you want. So I'm just using the rails tasks directly and dropped that dependency. Hopefully that's ok? |
Thanks @andrewhampton! |
The older version of combustion used by awesome_nested_set doesn't appear to be compatible with rails 7, and the latest version of combustion no longer has an API that lets you pass in a config. So this commit drops the dependency on combustion and just uses the rails task for database setup and teardown.
No description provided.