CGP-1446: Rebase PR To 7.x-5.x - Allow multiple values with same location without swapping primary keys #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion without swapping primary keys
KarinG
reviewed
Sep 20, 2019
| $is_primary_address_location_type = wf_crm_aval($contact, 'address:1:location_type_id'); | ||
| $is_primary_email_location_type = wf_crm_aval($contact, 'email:1:location_type_id'); | ||
| //$is_primary_address_location_type = wf_crm_aval($contact, 'address:1:location_type_id'); | ||
| //$is_primary_email_location_type = wf_crm_aval($contact, 'email:1:location_type_id'); | ||
|
|
There was a problem hiding this comment.
Can you please remove these two lines.
There was a problem hiding this comment.
@KarinG please let us know if there is anything more we can do on this to close it off? many thanks!
|
You're refactoring code that was introduced in this PR - to address the issue described here: #121 |
|
@jamienovick @vinuvarshith can you please check on the question Karin asked so we can get this PR closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is a rebase of PR#148. I was able to reproduce the issue as mentioned that PR on 7.x-5.x branch too and I can also confirm this PR fixes it.
Details
For more details and screenshots pls see PR#148