Make to_str no_std compatible #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch allows the use of the (applicable subset of the) to_str module possible under no_std with or without the alloc crate. To this end, a new feature flag for alloc is introduced (implied by std). All use of String in to_str is gated behind the alloc feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
&'static str-related methods into_strdo not requirestd, but cannot currently be used because they are mixed in with use ofStringandto_string().This patch allows the use of the (applicable subset of the) to_str module possible under no_std with or without the alloc crate.
To this end, a new feature flag for alloc is introduced (implied by std). All use of String in to_str is gated behind the alloc feature.