This repository has been archived by the owner on Jan 20, 2020. It is now read-only.
Arbitrary names for the default profile #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ily map to default
…bugging session ;)
|
|
Could you please make it so that the user can override the |
|
This is awesome, just tested locally and it works well. Just two things left:
Cheers |
grahamjenson
approved these changes
Apr 12, 2018
assume-role
Outdated
| @@ -252,14 +272,17 @@ assume-role(){ | |||
|
|
|||
| # USED FOR TESTING AND DEBUGGING | |||
| if [ "$DEBUG_ASSUME_ROLE" = "true" ]; then | |||
| echo "AWS_DEFAULT_PROFILE_ASSUME_ROLE=\"$AWS_DEFAULT_PROFILE_ASSUME_ROLE\";" | |||
There was a problem hiding this comment.
Move this output to the end, as the majority of tests take the lines to ensure their order.
assume-role
Outdated
| @@ -235,6 +254,7 @@ assume-role(){ | |||
|
|
|||
| # OUTPUTS ALL THE EXPORTS for eval $(assume-role [args]) | |||
| if [ "$OUTPUT_TO_EVAL" = "true" ]; then | |||
| echo "export AWS_DEFAULT_PROFILE_ASSUME_ROLE=\"$AWS_DEFAULT_PROFILE_ASSUME_ROLE\";" | |||
There was a problem hiding this comment.
Move this to the end. Not sure if it is necessary.
|
Pull request is reviewed and can be merged to master! |
|
Cheers I will publish to brew soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Coinbase,
Here's a simple changeset that does not break backwards compatibility (
defaultprofile stays the same if env var is not defined).This change just gives some flexibility for the assumption of the
defaultprofile naming.Please let us know if you require further changes, we would like to have those changes upstream :)
/ping @reisingerf