test: add entry controller tests #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set up test suite. - Mock `EntryServices`, `Request`, `Response`, and `NextFunction`. - Create test suite for `EntryController`. - Add tests for `getAllEntries`.
- Add `createEntry` tests. - Update mocks. - Simplify `mockReq`. - Make `mockNext` a `jest.Mock`. - Remove mocked services that there are no tests for. - Update `getEntry` wrt the updated `mockReq`.
- Add unit tests for updateEntry.
- Add unit tests for deleteEntry.
- Add unit tests for getEntryAnalysis.
- Resolve error: `entryAnalysis.toObject` is not a function.
- Remove unnecessary toObject cast.
- Add updateEntryAnalysis tests. - Remove unnecessary toObject cast on entryAnalysis returned from updateEntryAnalysis service.
…tryConversation tests
- Add `getEntryConversation` tests.
- Remove unnecessary `toObject` cast.
- Add `createEntryConversation` tests.
- Remove unused logic to check for empty response.
- An error will be thrown by `getAnalysisCompletion` in entryConversation.ts before this logic is reached.
- Add `updateEntryConversation` tests.
- Remove unnecessary `toObject` cast.
- Note that flash messages are not sent on successful update (see FIXME).
- Add test to `createEntry` test sub-suite.
ishaan000
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tests the entry controller with unit tests. The initial commit sets up the test suite and adds unit tests for
getAllEntries.