refactor: move calls to LLM into CdGpt services #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the functions getAnalysisContent and getChatContent from the models into a service layer above the model. The reasoning for this is to have a call to an external API encapsulated in a module that's separate from the EntryAnalysis and EntryConversation models so that they don't depend on it. Unit tests for these functions were also moved into a new test file, models/services/CdGpt.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: entry services needs to be refactored to use CdGpt services before this PR can be merged.
Moved the functions getAnalysisContent and getChatContent from the models into a service layer above the model. The reasoning for this is to have a call to an external API encapsulated in a module that's separate from the EntryAnalysis and EntryConversation models so that they don't depend on it.
Unit tests for these functions were also moved into a new test file, models/services/CdGpt.test.ts
Closes #173
Closes #174