refactor: update entry services refactoring #190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved code for udpating Entry into entry service module. Refactored Journal check into reusable function in entry controller. Added unit tests for updateEntry.
Create and update Entry service functions had lots of repeated code, so I refactored them to share more in common and reduce repetition.
Created new service module for CdGpt and moved entryAnalysis.getAnalysisCompletion into it. Refactored unit tests and dependencies on entryAnalysis.getAnalysisCompletion
Moved entryConversation.getChatContent into service layer and refactored code and unit tests depending on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors update operations in controllers/entry into separate functions and moves them to a new file /models/services/entry/entry.ts. It also adds unit tests for the update service functions.
This PR also refactors EntryAnalysis.getAnalysisContent and EntryChat.getChatContent by moving them from their model files and into a new service file, /models/services/CdGpt.ts, which will act as the interface with the LLM. Unit tests were moved from the models into a new test file for /models/services/CdGpt.ts.