Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create entry services refactoring #189

Closed
wants to merge 13 commits into from
Closed

refactor: create entry services refactoring #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9aba502
refactor: Start adding tests for entry controller
davidzlu Oct 3, 2024
6adb100
refactor: add documentation for entry services
davidzlu Oct 3, 2024
4208a08
refactor: create getPopulatedEntry function
davidzlu Oct 3, 2024
92521d1
refactor: write functions for entry reads
davidzlu Nov 1, 2024
6226299
revert: createEntry controller to ts migration branch
davidzlu Nov 1, 2024
44768ef
refactor: add more comments entry service
davidzlu Nov 1, 2024
9946306
fix: resolve build issue with Express.User type
davidzlu Nov 1, 2024
105cb37
refactor: remove validateEntryAnalysis from entry controller
davidzlu Nov 2, 2024
c658f12
refactor: extract createEntry service from controller
davidzlu Nov 2, 2024
7043bf9
refactor: push error handling in createEntry into service
davidzlu Nov 2, 2024
807daf3
refactor: move createEntryConversation to service
davidzlu Nov 2, 2024
7a7b675
test: unit test createEntryConversation
davidzlu Nov 2, 2024
4f84e8c
test: add error handling unit test createEntry
davidzlu Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion backend/src/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ app.use(passport.authenticate('session'));

// Passport config
passport.use(User.createStrategy());
// @ts-expect-error Error from mismatch between User model and Express.User types. Implemented same way as passport-local-mongoose docs suggest
passport.serializeUser(User.serializeUser());
passport.deserializeUser(User.deserializeUser());

Expand Down
3 changes: 1 addition & 2 deletions backend/src/controllers/access/access.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import {
import { NextFunction, Request, Response } from 'express';
import jwt, { JwtPayload } from 'jsonwebtoken';
import ExpressError from '../../utils/ExpressError.js';
import { HydratedDocument } from 'mongoose';
import { UserType } from '../../models/user.js';
import crypto from 'crypto';
import passport from 'passport';
Expand Down Expand Up @@ -248,7 +247,7 @@ export const login = async (req: Request, res: Response, next: NextFunction) =>
type AuthenticateInfo = {
message: string;
};
passport.authenticate('local', async (err: Error, user: HydratedDocument<UserType> | null, info: AuthenticateInfo) => {
passport.authenticate('local', async (err: Error, user: UserType | null, info: AuthenticateInfo) => {
if (err) {
return next(err);
}
Expand Down
Loading