Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed axis names for parallel coordinates #19

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

danyoungday
Copy link
Collaborator

Used the same hard-coded mapping that we use to modify the filter sliders for the parallel coordinates.

@danyoungday danyoungday requested a review from ofrancon November 5, 2024 21:18
@danyoungday danyoungday self-assigned this Nov 5, 2024
"Highest cost of energy",
"Government spending",
"Reduction in energy demand"]))

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move names_map into the constructor so we can use it in other functions

@@ -79,6 +83,7 @@ def plot_parallel_coordinates_line(self,
fig = go.Figure()

normalized_df = filter_metrics_json(metrics_json, metric_ranges, normalize=True)
normalized_df.rename(self.names_map, axis=1, inplace=True)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply rename the df before we plot it to fix the axis names

Copy link
Collaborator

@ofrancon ofrancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danyoungday danyoungday merged commit 81ba9c8 into main Nov 5, 2024
1 check passed
@danyoungday danyoungday deleted the fix-parcoord-axes branch November 5, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants