-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2] simplify text handlers as well #371
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrOrz
force-pushed
the
refactor-text-msg
branch
from
November 12, 2023 10:32
729d5ef
to
ffffb2a
Compare
MrOrz
changed the base branch from
id-in-context
to
revamp-postback-handlers
November 12, 2023 10:33
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
MrOrz
force-pushed
the
refactor-text-msg
branch
2 times, most recently
from
November 12, 2023 16:49
3554eb3
to
9c83fb4
Compare
MrOrz
changed the title
refacto(webhook): simplify text handlers as well
refactor(webhook): simplify text handlers as well
Nov 12, 2023
MrOrz
force-pushed
the
refactor-text-msg
branch
from
November 12, 2023 17:02
9c83fb4
to
1cf2ae9
Compare
Pull Request Test Coverage Report for Build 6842018647
💛 - Coveralls |
MrOrz
changed the title
refactor(webhook): simplify text handlers as well
[2] simplify text handlers as well
Nov 12, 2023
bil4444
approved these changes
Nov 15, 2023
This was referenced Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handleInput
andinitState
handler to handle just text eventshandleInput
is in charge of creating new (text) search sessioninitState
takes input text from search session, no need to compose an event for it, greatly simplifies stuffChatbotEvent
completely, as postback and text event handlers has their own eventsserver_choose
events and type forevent.input
, as we no longer need those.