Fix group message issues #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1286
💛 - Coveralls |
46e0cf4 to
b1b7fe2
Compare
And fix bugs 1. Custom metrics isn’t sent 2. Room/Group member count should use their own api
…`Reply` / `Selected` / `<selected reply id>`
b1b7fe2 to
e3fddfb
Compare
nonumpa
commented
Feb 22, 2021
| ); | ||
|
|
||
| const visitor = ga(groupId, 'N/A', '', otherFields.source.type); | ||
|
|
||
| visitor.set('cm1', groupMembersCount); |
There was a problem hiding this comment.
Because chatbot may join/leave a group multiple times,
we should find the last Join action of the Client Id to get a more accurate Group Members Count.
Don't know if there's a better way to handle this condition.
MrOrz
approved these changes
Feb 24, 2021
| @@ -49,6 +51,11 @@ export default async function processText(event, groupId) { | |||
| return { event, groupId, replies }; | |||
| } | |||
|
|
|||
| if (event.input.toLowerCase() === LEAVE_KEYWORD) { | |||
| await lineClient.post(`/${event.source.type}/${groupId}/leave`); | |||
There was a problem hiding this comment.
Does this trigger leave webhook? If not, we may need to manually send ga here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix remain issues from PR #238
Others