Skip to content

Commit

Permalink
--build_event_json_file should imply `--bes_upload_mode=wait_for_up…
Browse files Browse the repository at this point in the history
…load_complete`.

In unknown commit we did the same for `--build_event_binary_file` - similar to
the binary file, the JSON file is often used by tools who will then see an
incomplete JSON file and fail parsing it.

PiperOrigin-RevId: 545589136
Change-Id: I03c0ed867c6b652098a1d5a7e546ce06bc9a4dca
  • Loading branch information
meisterT authored and copybara-github committed Jul 5, 2023
1 parent 9b7730c commit 232d848
Showing 1 changed file with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,12 @@ public class BuildEventStreamOptions extends OptionsBase {
name = "build_event_json_file",
oldName = "experimental_build_event_json_file",
defaultValue = "",
implicitRequirements = {"--bes_upload_mode=wait_for_upload_complete"},
documentationCategory = OptionDocumentationCategory.LOGGING,
effectTags = {OptionEffectTag.AFFECTS_OUTPUTS},
help = "If non-empty, write a JSON serialisation of the build event protocol to that file.")
help =
"If non-empty, write a JSON serialisation of the build event protocol to that file."
+ " This option implies --bes_upload_mode=wait_for_upload_complete.")
public String buildEventJsonFile;

@Option(
Expand Down

0 comments on commit 232d848

Please sign in to comment.