DEV2-564 Enhance context gathering in Jupyter notebooks by including text from… #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… all cells Signed-off-by: Tal Wertheimer <tal@Tals-MacBook-Pro-2.local>
dimacodota
reviewed
Dec 13, 2023
src/runCompletion.ts
Outdated
| @@ -1,4 +1,5 @@ | |||
| import { CancellationToken, Position, Range, TextDocument } from "vscode"; | |||
| import * as vscode from "vscode"; | |||
There was a problem hiding this comment.
there is a named import from vscode one line above, just add the window and the Uri to it
dimacodota
reviewed
Dec 13, 2023
src/runCompletion.ts
Outdated
| notebookEditor, | ||
| document.uri | ||
| ); | ||
| requestData.before = [before, requestData.before].join("\n"); |
There was a problem hiding this comment.
i'd prefer an approach that's more "immutable". how about introducing a getContextParts function that returns something like {before: string, after: string}? this function could calculate the 'before' and 'after' based on whether it's a notebook or a regular document, instead of directly mutating the requestData. WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… all cells