Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV2-4342 fix tabnine.enterprise key #1390

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Conversation

yonip23
Copy link
Contributor

@yonip23 yonip23 commented Dec 3, 2023

this line from the CI fails the build:
test "$(cat temp/extension/out/extension.js | grep tabnine.enterprise | wc -l)" = "0"
because I added "tabnine.enterprise" to the non-enterprise plugin in this line:
isSelfHosted: context.workspaceState.get(TABNINE_ENTERPRISE_KEY, false), 🤦🏻

Solution

change the key that's used in the non-enterprise plugin to tabnine.isSelfHosted 🤦🏻

Proof it works

I built the extension locally from this branch and ran the line from the CI:

➜  tabnine-vscode git:(DEV2-4342-fix-release) ✗ test "$(cat temp/extension/out/extension.js | grep tabnine.enterprise | wc -l)" = "0"
➜  tabnine-vscode git:(DEV2-4342-fix-release) ✗ echo $?
0

@yonip23 yonip23 requested a review from yonidavidson December 3, 2023 13:29
@yonip23 yonip23 requested a review from a team as a code owner December 3, 2023 13:30
@yonip23 yonip23 requested a review from dimacodota December 3, 2023 13:30
Copy link
Contributor

@amircodota amircodota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yonip23 yonip23 merged commit 7c1f1ea into master Dec 3, 2023
3 checks passed
@yonip23 yonip23 deleted the DEV2-4342-fix-release branch December 3, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants