Add keyboard shortcuts for markdown text editor #508
Conversation
| break; | ||
|
|
||
| case 75: | ||
| ev.preventDefault(); |
There was a problem hiding this comment.
Why are only some of these using ev.preventDefault()? Do the others work without it?
There was a problem hiding this comment.
yep that's right, specifically ev.preventDefault() is for Ctrl+P (opens the print dialog), Ctrl+K (focuses on the browser search bar), and Ctrl+U (opens the page source). The rest work without it.
There was a problem hiding this comment.
For the other cases, is preventDefault() a no-op or does it not work (because there is no default)? If the former, I'm wondering if we should do it for all of them in case browsers add more overlapping key bindings in the future. Disclosure: this is not my area, so if this is a dumb question please let me know.
There was a problem hiding this comment.
Ah, of course. I'm thinking of the default being "insert letter", but of course it's not if it's Ctrl. Thanks.
Resolves #274 - Add the following keyboard shortcuts for the markdown text editor as mentioned in the issue