Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating hover text of upvote and downvote #478

Merged
merged 4 commits into from
Apr 25, 2021

Conversation

b-Istiak-s
Copy link
Contributor

Earlier it was only showing score point which was very confusing. And, new user would know by seeing the hover text what it does.

Earlier it was only showing score point which was very confusing. And, new user would know by seeing the hover text what it does.
@ArtOfCode-
Copy link
Member

Thanks! Can we make these just say "Score: <%= post.score %>" instead? I don't think it needs any further explanation in the tooltip. (New lines also don't have great cross-browser support.)

@cellio
Copy link
Member

cellio commented Apr 22, 2021

Thanks! Can we make these just say "Score: <%= post.score %>" instead? I don't think it needs any further explanation in the tooltip. (New lines also don't have great cross-browser support.)

Can we add "(0-1)" or "(scale: 0-1)" after the score? The fractional values might confuse folks expecting "up minus down".

@b-Istiak-s
Copy link
Contributor Author

Thanks! Can we make these just say "Score: <%= post.score %>" instead? I don't think it needs any further explanation in the tooltip. (New lines also don't have great cross-browser support.)

New lines also don't have great cross-browser support. I didn't have the idea. That's why I wrote it. Cause, sometimes new user get issue to understand what does it do. When I was completely new to SO I was checking all of them cause, I didn't know what they do. Even, I forgot to read hover text. Than, "Score: <%= post.score %>" is ok.! :)

@b-Istiak-s
Copy link
Contributor Author

Thanks! Can we make these just say "Score: <%= post.score %>" instead? I don't think it needs any further explanation in the tooltip. (New lines also don't have great cross-browser support.)

Can we add "(0-1)" or "(scale: 0-1)" after the score? The fractional values might confuse folks expecting "up minus down".

I think no! Cause, 'upvote' and 'downvote' score shows between those buttons. So, I don't think it is necessary.

@cellio
Copy link
Member

cellio commented Apr 23, 2021

Oh right, the vote breakdown is right there -- so people should be able to interpret the number with the additional hint that it's a score.

@ArtOfCode- ArtOfCode- merged commit 9191b61 into codidact:develop Apr 25, 2021
@cellio
Copy link
Member

cellio commented May 11, 2021

Fixes https://meta.codidact.com/posts/281409. (I thought I created an issue for this, but if so I didn't find it.)

@b-Istiak-s b-Istiak-s deleted the patch-1 branch August 16, 2021 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants