Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds unique index on note and user id of teams table #286

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

Tushar504
Copy link
Contributor

@Tushar504 Tushar504 commented Jan 25, 2025

@Tushar504 Tushar504 linked an issue Jan 25, 2025 that may be closed by this pull request
@Tushar504 Tushar504 requested review from e11sy and neSpecc January 25, 2025 14:10
Copy link
Member

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you been able to reproduce the problem?
Please provide a detailed explanation of the issue, its root cause, and your solution in the PR description

@Tushar504
Copy link
Contributor Author

Have you been able to reproduce the problem? Please provide a detailed explanation of the issue, its root cause, and your solution in the PR description

  • I am not able reproduce the problem
  • if we add the unique key constraints then it won't allow duplicate entry into db.

@Tushar504 Tushar504 force-pushed the 285-fix-join-route-user-duplication branch from 11a8aae to 0d61638 Compare February 5, 2025 10:58
@Tushar504 Tushar504 requested review from e11sy and neSpecc February 5, 2025 13:31
Copy link

github-actions bot commented Feb 5, 2025

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 85.94% (🎯 80%)
⬆️ +0.01%
8576 / 9978
🟢 Statements 85.94% (🎯 80%)
⬆️ +0.01%
8576 / 9978
🔴 Functions 79.22% (🎯 80%)
🟰 ±0%
267 / 337
🟢 Branches 85.4% (🎯 80%)
🟰 ±0%
427 / 500
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/repository/storage/postgres/orm/sequelize/teams.ts 99.19%
⬆️ +0.02%
85.71%
🟰 ±0%
100%
🟰 ±0%
99.19%
⬆️ +0.02%
197-198
Generated in workflow #873 for commit 7bf4dfe by the Vitest Coverage Report Action

@Tushar504 Tushar504 requested a review from e11sy February 5, 2025 16:25
@Tushar504 Tushar504 merged commit f5f2379 into main Feb 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Fix join route user duplication
3 participants