Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #148: Improved by automatic switching between dark and ligh… #149

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Fix issue #148: Improved by automatic switching between dark and ligh… #149

merged 2 commits into from
Sep 11, 2024

Conversation

D-01576
Copy link
Contributor

@D-01576 D-01576 commented Sep 9, 2024 •
edited
Loading

Fixes issue #148: improve by automatic switching between dark and light mode based on the user's system preference

What this PR does:

  • automatic switching between dark and light mode based on the user's system preference

@D-01576
Fix issue codesupport#148: Improved by automatic switching between da…
03e4b85 
…rk and light mode based on the user's system preference
@D-01576
Copy link
Contributor Author

D-01576 commented Sep 9, 2024

@LamboCreeper, @Jason2605 please review this PR

LamboCreeper
LamboCreeper reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@LamboCreeper LamboCreeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Looks good, but could you update it so there is no black text on the blue buttons and hero banners. It is hard to read (see below):
image
image

@D-01576
Copy link
Contributor Author

D-01576 commented Sep 11, 2024

@LamboCreeper, Ok

@D-01576
Copy link
Contributor Author

D-01576 commented Sep 11, 2024

@LamboCreeper, Updated now you can check

LamboCreeper
LamboCreeper approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@LamboCreeper LamboCreeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you for this

@LamboCreeper LamboCreeper merged commit b9b27e7 into codesupport:master Sep 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LamboCreeper LamboCreeper LamboCreeper approved these changes

@Jason2605 Jason2605 Awaiting requested review from Jason2605 Jason2605 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@D-01576 @LamboCreeper