-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and clarify cases in ignore patterns #3583
base: main
Are you sure you want to change the base?
Conversation
In this case, the potential typos are valid proper nouns (names). |
Hi @DimitriPapadopoulos thanks for your comment.
I still don't really understand the behaviour, should I expect a word in my target file like |
This dictionary is not part of the default dictionaries. |
okay thanks for the reply |
Can you look into this please? @larsoner @peternewman |
Marking for merge-when-green, thanks in advance @DanielYang59 ! |
No worries at all, thanks for reviewing :) |
@larsoner Maybe forgot to trigger auto-merge? |
Follow up #3580 (comment).
Question:
README.rst
but looks like it's a global ignore dict instead of a correction dict (i.e. any pattern in this dict would be ignore?).codespell/codespell_lib/_codespell.py
Lines 119 to 120 in 07a4645