Update ruff settings #3558
Merged
Update ruff settings #3558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable deprecated/problematic rules.
RUF022 `__all__` is not sorted
PLC0206 Extracting value from dictionary without calling `.items()`
PLW1514 `open` in text mode without explicit `encoding` argument
They do not seem worth applying in existing code.
F841 Local variable is assigned to but never used
larsoner
approved these changes
Oct 2, 2024
| "COM819", | ||
| "ISC001", | ||
| "ISC002", | ||
| ] |
There was a problem hiding this comment.
Makes me think we should add toml-sort pre-commit at some point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@larsoner Could you review this PR?