Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI issues #2796

Merged
merged 2 commits into from
Mar 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion codespell_lib/_codespell.py
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,7 @@ def parse_options(
cfg_args.append(f"--{key}")
# If value is blank, skip.
val = config["codespell"][key]
if val != "":
if val:
cfg_args.append(val)

# Parse config file options.
Expand Down
8 changes: 4 additions & 4 deletions codespell_lib/tests/test_basic.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def test_basic(
assert isinstance(result, tuple)
code, stdout, stderr = result
assert code == 0
assert stdout == stderr == ""
assert not stdout and not stderr
assert cs.main(tmp_path) == 0

# empty directory
Expand Down Expand Up @@ -266,7 +266,7 @@ def test_summary(
assert isinstance(result, tuple)
code, stdout, stderr = result
assert code == 0
assert stdout == stderr == "", "no output"
assert not stdout and not stderr, "no output"
result = cs.main(fname, "--summary", std=True)
assert isinstance(result, tuple)
code, stdout, stderr = result
Expand Down Expand Up @@ -375,12 +375,12 @@ def test_encoding(
assert isinstance(result, tuple)
code, stdout, stderr = result
assert code == 0
assert stdout == stderr == ""
assert not stdout and not stderr
result = cs.main("-q", "0", fname, std=True, count=False)
assert isinstance(result, tuple)
code, stdout, stderr = result
assert code == 0
assert stdout == ""
assert not stdout
assert "WARNING: Binary file" in stderr


Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ addopts = "--cov=codespell_lib -rs --cov-report= --tb=short --junit-xml=junit-re
extend-ignore = [
"ANN101",
"B904",
"PLC1901",
"PLW2901",
]
line-length = 88
Expand Down