Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setup.py #2626

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Remove setup.py #2626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/codespell-private.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
run: |
python --version # just to check
pip install -U pip wheel # upgrade to latest pip find 3.5 wheels; wheel to avoid errors
pip install --upgrade chardet "setuptools!=47.2.0" docutils setuptools_scm[toml]
pip install --upgrade chardet "setuptools!=47.2.0" docutils setuptools_scm[toml] twine
pip install aspell-python-py3
pip install -e ".[dev]" # install the codespell dev packages
- run: codespell --help
Expand Down
11 changes: 7 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ SORT_ARGS := -f -b

DICTIONARIES := codespell_lib/data/dictionary*.txt

PHONY := all check check-dictionaries sort-dictionaries trim-dictionaries check-dictionary sort-dictionary trim-dictionary check-manifest check-distutils flake8 pytest pypi clean
PHONY := all check check-dictionaries sort-dictionaries trim-dictionaries check-dictionary sort-dictionary trim-dictionary check-manifest check-dist flake8 pytest pypi clean

all: check-dictionaries codespell.1

check: check-dictionaries check-manifest check-distutils flake8 pytest
check: check-dictionaries check-manifest check-dist flake8 pytest

check-dictionary: check-dictionaries
sort-dictionary: sort-dictionaries
Expand Down Expand Up @@ -47,8 +47,11 @@ trim-dictionaries:
check-manifest:
check-manifest --no-build-isolation

check-distutils:
python setup.py check --restructuredtext --strict
check-dist:
$(eval TMP := $(shell mktemp -d))
python -m build -o $(TMP)
Copy link
Collaborator

@DimitriPapadopoulos DimitriPapadopoulos Nov 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires build, but build has not been added as a dependency in pyproject.toml.

twine check --strict $(TMP)/*
rm -rf $(TMP)

flake8:
flake8
Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ cache:

install:
- "SET PATH=%PYTHON%;%PYTHON%\\Scripts;%PATH%"
- "python.exe -m pip install -U pip"
- "pip install codecov chardet setuptools"
- "pip install -e \".[dev]\"" # install the codespell dev packages
- "python setup.py develop"

build: false # Not a C# project, build stuff at the test step instead.

Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ types = [
"mypy",
"pytest",
"types-chardet",
"types-setuptools",
]

[project.scripts]
Expand Down
6 changes: 0 additions & 6 deletions setup.py
View file
Open in desktop

This file was deleted.