-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2055: Add support for PEP 518 #2290
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e82eca2
Fix #2055: Add support for PEP 518
Freed-Wu 12232f1
TST: Add test
larsoner 3d2e5dd
ENH: Bump ver
larsoner 4bf10c1
FIX: Comment
larsoner 2864523
FIX: Syntax
larsoner bdc26eb
Merge remote-tracking branch 'upstream/master' into iss2055
larsoner 6bd2a63
FIX: Permissive
larsoner 3e1fdb7
FIX: Permissive
larsoner 79880ed
FIX: Explicit better than implicit
larsoner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,7 +23,7 @@ Useful links | |
Requirements | ||
------------ | ||
|
||
Python 3.6 or above. | ||
Python 3.7 or above. | ||
|
||
Installation | ||
------------ | ||
|
@@ -107,6 +107,13 @@ This is equivalent to running:: | |
|
||
codespell --quiet-level 3 --count --skip "*.po,*.ts,./src/3rdParty,./src/Test" | ||
|
||
Now codespell also support ``pyproject.toml``:: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ...via the --toml argument |
||
|
||
[tool.codespell] | ||
skip = '*.po,*.ts,./src/3rdParty,./src/Test' | ||
count = '' | ||
quiet-level = 3 | ||
|
||
Any options specified in the command line will *override* options from the | ||
config file. | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@larsoner can we have a comment explaining what this is trying to achieve. It looks like the old fail-fast would have done the same thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fail-fast cancels jobs within an action if one of them fails
this cancels jobs if another commit is pushed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, although do we want fail-fast too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that our tests are fast enough already and as we add others (different OSes etc) they can potentially show different problems. But we reenable it if you want
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumably it won't start testing the next commit until the last one is done?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With
cancel-in-progress: true
if you push a commit it kills runs from a previous commit. But all jobs from a given commit are allowed to run to completion (because offail-fast: false
) so you can see potentially different errors for your latest commitTo me it's the most reasonable behavior, as it's how Travis behaved from the start years ago IIRC and most CI providers followed suit (or at least provided an option for it) and has seemed like a good compromise over the years