Add bl-ue's accumulated fixes #2266
Conversation
28935c2 to
9dc973a
Compare
|
@vikivivi do you mind reviewing this PR ? |
Split off from codespell-project#2266
Split off from codespell-project#2266
codespell_lib/data/dictionary.txt
Outdated
| improted->imported | ||
| improter->importer | ||
| improting->importing | ||
| improts->imporsts |
There was a problem hiding this comment.
The suggested word improts->imporsts is a misspell.
improts->imports
improtantly->importantly
improters->importers
improtance->importance
improtation->importation
improtations->importations
| cteateing->creating | ||
| cteater->creator | ||
| cteates->creates | ||
| cteating->creating |
There was a problem hiding this comment.
Would you mind adding this?
cteation->creation
cteations->creations
| aotomatic->automatic | ||
| aotomatical->automatic | ||
| aotomaticall->automatically | ||
| aotomatically->automatically |
There was a problem hiding this comment.
aotomate->automate
aotomated->automated
aotomation->automation
codespell_lib/data/dictionary.txt
Outdated
| @@ -18740,12 +18810,13 @@ japanses->Japanese | |||
| jaques->jacques | |||
| javacript->javascript | |||
| javascipt->javascript | |||
| JavaSciript->JavaScript | |||
| Javasciript->Javascript | |||
There was a problem hiding this comment.
The word JavaScript is normally written in CamelCase. A search will show the result.
Shall we change all to JavaScript with capital J and S? IMO, the dictionary should hold true to the actual represented spelling form.
There was a problem hiding this comment.
I removed the capitalization altogether. I don't think it makes sense to always capitalize programming languages. Most of the time in source code comments folks keep things pretty informal. My observation and also opinion
There was a problem hiding this comment.
In my opinion, those folks who make an effort for their code quality, documentation and spelling will use tools like codespell. Those folks who can't be bothered and want things to be informal, would mostly likely not be using quality checking tools.
The results from hunspell, aspell and ispell. All of them indicate a misspell and proposed JavaScript.
When I am typing this reply using Chrome browser, the browser recognises Javascript as misspelled, the word is underlined with a wavy red line. When I type in CamelCase, the wavy red line disappeared.
I understand codespell is not supporting CamelCase now, but it should not prevent us from getting dictionary in shape. IMO, the dictionary should hold true to what it should be. Not based on informal folks way of writing. People will then feel confident. @peternewman what do you think?
### hunspell: /usr/share/hunspell: en_GB
& Javascript 3 0: JavaScript, Java script, Java-script
### hunspell: /usr/share/hunspell: en_US
& Javascript 3 0: JavaScript, Java script, Java-script
### aspell: /var/lib/aspell: en_GB
& Javascript 4 0: JavaScript, Java script, Java-script, JavaScript's
### aspell: /var/lib/aspell: en_US
& Javascript 4 0: JavaScript, Java script, Java-script, JavaScript's
### ispell: /usr/share/ispell: british-insane
& Javascript 3 0: JavaScript, Java script, Java-script
### ispell: /usr/share/ispell: american-insane
& Javascript 3 0: JavaScript, Java script, Java-script
### look: marcoagpinto/aoo-mozilla-en-dict: en_GB (Marco Pinto)
JavaScript
### look: marcoagpinto/aoo-mozilla-en-dict: en_US (Kevin Atkinson)
JavaScript
There was a problem hiding this comment.
I understand your point.
There was a problem hiding this comment.
I've opened #2426 to discuss this in more detail, and unblock the merging of this PR because it's a separate issue altogether (preexisting entries are also called in to question).
|
Added @vikivivi feedback, squashed and rebased |
Add refinements Fix formatting error fix codespell formatting Add revisions by vikivivi
Split off from codespell-project#2266 Co-authored-by: Dimitri Papadopoulos Orfanos <3234522+DimitriPapadopoulos@users.noreply.github.com>
Split off from codespell-project#2266 Co-authored-by: Dimitri Papadopoulos Orfanos <3234522+DimitriPapadopoulos@users.noreply.github.com>
Split off from codespell-project#2266 Co-authored-by: Dimitri Papadopoulos Orfanos <3234522+DimitriPapadopoulos@users.noreply.github.com>
Split off from codespell-project#2266
Cleaning out my local backlog of branches. This one was from @bl-ue. I've added some refinements.