Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more misspelled words #1598

Merged
merged 6 commits into from
Jul 22, 2020
Merged

Add more misspelled words #1598

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
97dbf63
Added denstiy
sebweb3r Jul 13, 2020
a85f722
Added diskretization
sebweb3r Jul 18, 2020
af9d4e3
Added suggestions
sebweb3r Jul 21, 2020
d55d103
Add discretized
sebweb3r Jul 21, 2020
ae5b421
Added more words
sebweb3r Jul 21, 2020
059758d
Deleted words not included in aspell.
sebweb3r Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions codespell_lib/data/dictionary.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8150,6 +8150,7 @@ demudulator->demodulator
denegrating->denigrating
densitity->density
densly->densely
denstiy->density
deocder->decoder
deoes->does
deoesn't->doesn't
Expand Down Expand Up @@ -9279,6 +9280,12 @@ disignated->designated
disinguish->distinguish
disiplined->disciplined
disired->desired
diskrete->discrete
diskretion->discretion
diskretization->discretization
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the sation variant as a separate typo please.

Also the Wikipedia page mentions discretized, so it might be worth adding this typo against that word and maybe also discrete, discretely, discretion etc. Possibly also discuss etc (although grep.app doesn't find examples of the latter).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some of your suggestions. I think I will make/lookup a list of commonly misspelled words by germans and add it in my holidays.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peternewman i don't understand the travis checks.
f.e. diskretization is for sure not in aspell, since it is wrong.
or https://en.wiktionary.org/wiki/discretise exists :-)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some of your suggestions. I think I will make/lookup a list of commonly misspelled words by germans and add it in my holidays.

Great, the trick there is probably to add a new dictionary called dictionary-de.txt and if necessary move anything in the main dictionary that's a valid German word (like some of my other suggestions) out into a dictionary-en.txt (and make that default). Then ideally make Travis check all that complication too!

@peternewman i don't understand the travis checks.
f.e. diskretization is for sure not in aspell, since it is wrong.
or https://en.wiktionary.org/wiki/discretise exists :-)

See my comments for some further explanation.

diskretize->discretize
diskretized->discretized
diskrimination->discrimination
dislaimer->disclaimer
dislay->display
dislayed->displayed
Expand Down
6 changes: 6 additions & 0 deletions codespell_lib/data/dictionary_en-GB_to_en-US.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@ customising->customizing
dialogue->dialog
digitise->digitize
digitising->digitizing
discretisation->discretization
discretise->discretize
discretised->discretized
peternewman marked this conversation as resolved.
Show resolved Hide resolved
diskretisation->discretization
diskretise->discretize
diskretised->discretized
peternewman marked this conversation as resolved.
Show resolved Hide resolved
emphasised->emphasized
flavour->flavor
flavours->flavors
Expand Down