Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add origin checks to web sockets #6048

Merged
merged 5 commits into from
Mar 3, 2023
Merged

Conversation

code-asher
Copy link
Member

No description provided.

I will be making use of this to parse the forwarded header.
Also add some test cases.
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #6048 (f676015) into main (ac1fba8) will increase coverage by 1.03%.
The diff coverage is 91.66%.

❗ Current head f676015 differs from pull request most recent head ffde71a. Consider uploading reports for the commit ffde71a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6048      +/-   ##
==========================================
+ Coverage   72.08%   73.12%   +1.03%     
==========================================
  Files          30       30              
  Lines        1666     1704      +38     
  Branches      364      374      +10     
==========================================
+ Hits         1201     1246      +45     
+ Misses        389      383       -6     
+ Partials       76       75       -1     
Impacted Files Coverage Δ
src/node/wsRouter.ts 92.00% <ø> (ø)
src/node/routes/domainProxy.ts 60.00% <50.00%> (-1.54%) ⬇️
src/node/routes/errors.ts 85.71% <66.66%> (+2.38%) ⬆️
src/node/http.ts 68.75% <96.77%> (+12.62%) ⬆️
src/common/http.ts 100.00% <100.00%> (ø)
src/node/cli.ts 91.43% <100.00%> (-0.10%) ⬇️
src/node/routes/pathProxy.ts 82.14% <100.00%> (+15.47%) ⬆️
src/node/routes/vscode.ts 37.17% <100.00%> (ø)
src/node/util.ts 88.70% <100.00%> (+0.18%) ⬆️
src/node/routes/index.ts 76.63% <0.00%> (+0.93%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a47cd81...ffde71a. Read the comment docs.

@code-asher code-asher force-pushed the origin-checks branch 3 times, most recently from 0c08bfa to f676015 Compare March 3, 2023 03:41
@code-asher code-asher marked this pull request as ready for review March 3, 2023 06:57
@code-asher code-asher requested a review from a team as a code owner March 3, 2023 06:57
@code-asher code-asher merged commit d477972 into coder:main Mar 3, 2023
@code-asher code-asher deleted the origin-checks branch March 3, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant