Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated --link #6018

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Remove deprecated --link #6018

merged 1 commit into from
Feb 13, 2023

Conversation

code-asher
Copy link
Member

No description provided.

@code-asher code-asher requested a review from a team as a code owner February 13, 2023 22:04
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #6018 (ecb08cc) into main (45aef71) will increase coverage by 0.50%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6018      +/-   ##
==========================================
+ Coverage   71.58%   72.08%   +0.50%     
==========================================
  Files          31       30       -1     
  Lines        1700     1666      -34     
  Branches      372      364       -8     
==========================================
- Hits         1217     1201      -16     
+ Misses        405      389      -16     
+ Partials       78       76       -2     
Impacted Files Coverage Δ
src/node/cli.ts 91.53% <ø> (-0.23%) ⬇️
src/node/main.ts 49.46% <100.00%> (-0.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36daac3...ecb08cc. Read the comment docs.

@code-asher code-asher merged commit ac1fba8 into coder:main Feb 13, 2023
@code-asher code-asher deleted the remove-link branch February 13, 2023 22:52
@code-asher
Copy link
Member Author

code-asher commented Feb 13, 2023

@benz0li @bala I am making one more RC to squeeze this change in, then I am thinking we can do the regular release tomorrow morning.

@benz0li
Copy link
Contributor

benz0li commented Feb 14, 2023

@code-asher Same outcome for Release v4.10.0-rc.2 as #6004 (comment).

@Tyriar Use image R (base:test-devtools) at https://coder.jupyter.b-data.ch/ for Code 1.75.1.
ℹ️ Image R (jupyterlab/r/verse:latest-devtools) runs Code 1.73.1.

@code-asher
Copy link
Member Author

@benz0li thank you again for all the testing help!!

@stpoa
Copy link

stpoa commented Feb 27, 2023

Why did you remove the --link option?

@code-asher
Copy link
Member Author

code-asher commented Feb 27, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants