Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: simplify termux installation process #5078

Merged
merged 9 commits into from
Apr 12, 2022
Merged

docs: simplify termux installation process #5078

merged 9 commits into from
Apr 12, 2022

Conversation

thx2001r
Copy link
Contributor

@thx2001r thx2001r commented Apr 9, 2022

  1. Updated information to use PRoot (simpler than Andronix and the way supported by Termux) to create and access the Debian distro.
  2. Added helpful information on using PRoot with your dev environment.
  3. Cleaned up spelling, grammar, and made documentation more consistent between sections.

Fixes #

@thx2001r
Update termux.md
90a3cd7 
1) Updated information to use PRoot (simpler than Andronix and the way supported by Termux) to create and access the Debian distro.
2) Added helpful information on using PRoot with your dev environment.
3) Cleaned up spelling, grammar, and made documentation more consistent between sections.
@thx2001r thx2001r requested a review from a team April 9, 2022 20:27
@thx2001r thx2001r changed the title Update termux.md docs: simplify termux installation process Apr 9, 2022
@thx2001r
docs: Termux correct packages to install
f3c0dab 
Updated some erroneously missing packages (vim and sudo) necessary for multi-user setup.
@thx2001r
Copy link
Contributor Author

Please take a look at the screen recording demonstrating the updated documentation working on the latest Termux on Android 12 on a Samsung Galaxy S21 in DeX mode:

https://youtu.be/Stu8eSALLw8

jsjoeio
jsjoeio suggested changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement with all the extra info added! Thank you so much!

Just a couple minor suggestions

@jsjoeio jsjoeio self-assigned this Apr 11, 2022
@jsjoeio jsjoeio added the docs Documentation related label Apr 11, 2022
@jsjoeio jsjoeio added this to the April 2022 milestone Apr 11, 2022
thx2001r and others added 4 commits April 11, 2022 20:48
@thx2001r @jsjoeio
docs: cleaned up verbiage
e2197c0 
Co-authored-by: Joe Previte <jjprevite@gmail.com>
@thx2001r @jsjoeio
docs: corrected punctuation
77309f2 
Co-authored-by: Joe Previte <jjprevite@gmail.com>
@thx2001r @jsjoeio
docs: correct punctuation
8168168 
Co-authored-by: Joe Previte <jjprevite@gmail.com>
@thx2001r
docs: clarify pkg command shorthand
c06ac4f
@thx2001r thx2001r requested a review from jsjoeio April 12, 2022 00:55
jsjoeio
jsjoeio approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the force is strong with this one

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 12, 2022

My least favorite part of our build step. Can you run yarn fmt? Sorry for the hassle!

image

@thx2001r
Copy link
Contributor Author

Not sure how to do that as I made the commits and pull request directly in Github and don't have a code-server dev environment setup. Ideas?

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 12, 2022

Not sure how to do that as I made the commits and pull request directly in Github and don't have a code-server dev environment setup. Ideas?

Hmm, what if I submit a PR to your fork, you merge and then update this branch?

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 12, 2022

@thx2001r can you add me (jsjoeio) as a collaborator on your fork?

image

@thx2001r
Copy link
Contributor Author

thx2001r commented Apr 12, 2022 •
edited
Loading

Ok, checked out my branch locally, and was able to npm run fmt and commited the change that way. Does that work?

@thx2001r thx2001r requested a review from jsjoeio April 12, 2022 20:20
@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 12, 2022

Ok, checked out my branch locally, and was able to npm run fmt and commited the change that way. Does that work?
It should 🤞🏼

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #5078 (5c7ec6a) into main (f4569f0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5078   +/-   ##
=======================================
  Coverage   71.30%   71.30%           
=======================================
  Files          30       30           
  Lines        1683     1683           
  Branches      373      373           
=======================================
  Hits         1200     1200           
  Misses        413      413           
  Partials       70       70

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4569f0...5c7ec6a. Read the comment docs.

@thx2001r
Copy link
Contributor Author

Cool, looks like it worked! Cloned the branch to local on Termux and checked in with code-server running on the same Termux for fun. What is the next step?

@jsjoeio jsjoeio merged commit 3bf470f into coder:main Apr 12, 2022
@jsjoeio jsjoeio modified the milestones: April 2022, 4.3.0 Apr 13, 2022
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
@thx2001r @jsjoeio @TinLe
docs: simplify termux installation process (coder#5078)
a0af39a 
* Update termux.md

1) Updated information to use PRoot (simpler than Andronix and the way supported by Termux) to create and access the Debian distro.
2) Added helpful information on using PRoot with your dev environment.
3) Cleaned up spelling, grammar, and made documentation more consistent between sections.

* docs: Termux correct packages to install

Updated some erroneously missing packages (vim and sudo) necessary for multi-user setup.

* docs: cleaned up verbiage

Co-authored-by: Joe Previte <jjprevite@gmail.com>

* docs: corrected punctuation

Co-authored-by: Joe Previte <jjprevite@gmail.com>

* docs: correct punctuation

Co-authored-by: Joe Previte <jjprevite@gmail.com>

* docs: clarify pkg command shorthand

* Ran yarn fmt on docs

Co-authored-by: Joe Previte <jjprevite@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio Awaiting requested review from jsjoeio

Assignees

@jsjoeio jsjoeio

Labels
docs Documentation related
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thx2001r @jsjoeio