Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding option --edge to install latest edge / preview version #4605

Merged
merged 2 commits into from
Dec 14, 2021
Merged

adding option --edge to install latest edge / preview version #4605

merged 2 commits into from
Dec 14, 2021

Conversation

Leask
Copy link
Contributor

@Leask Leask commented Dec 11, 2021

Adding option --edge to install latest edge / preview version.

$ ./install.sh --edge true
$ ./install.sh --edge=true

@Leask Leask requested a review from a team as a code owner December 11, 2021 02:31
code-asher
code-asher previously requested changes Dec 13, 2021
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fantastic idea!

install.sh Outdated
@@ -32,6 +32,9 @@ Usage:
--version X.X.X
Install a specific version instead of the latest.

--edge [true | false (default) ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we leave off the value and set this to true when the flag is set? This is how we have been handling booleans, for example see --dry-run.

jsjoeio
jsjoeio reviewed Dec 13, 2021
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fantastic idea! I agree with @code-asher's feedback. Let's mimic how --dry-run is used. If flag passed, set to true else false.

@codecov
Copy link

codecov bot commented Dec 13, 2021 •
edited
Loading

Codecov Report

Merging #4605 (6edb195) into main (c77999b) will not change coverage.
The diff coverage is n/a.

❗ Current head 6edb195 differs from pull request most recent head 746f55a. Consider uploading reports for the commit 746f55a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4605   +/-   ##
=======================================
  Coverage   66.14%   66.14%           
=======================================
  Files          30       30           
  Lines        1654     1654           
  Branches      331      331           
=======================================
  Hits         1094     1094           
  Misses        475      475           
  Partials       85       85

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c77999b...746f55a. Read the comment docs.

@Leask
Copy link
Contributor Author

Leask commented Dec 13, 2021

Adding this commit: updated arg --edge parsing to match the style of --dryrun
746f55a
Thanks for the review :)

@Leask Leask requested a review from code-asher December 14, 2021 03:19
jsjoeio
jsjoeio approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! Thanks so much

@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 14, 2021

(You can ignore Docs preview - I need to fix it)

@Leask
Copy link
Contributor Author

Leask commented Dec 14, 2021

Thanks!

@jsjoeio jsjoeio dismissed code-asher’s stale review December 14, 2021 22:30

Changes requested were made

@jsjoeio jsjoeio merged commit 18e66c4 into coder:main Dec 14, 2021
@jsjoeio jsjoeio added this to the 4.0.0 milestone Dec 14, 2021
@Leask
Copy link
Contributor Author

Leask commented Dec 14, 2021

🆒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

@code-asher code-asher Awaiting requested review from code-asher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Leask @jsjoeio @code-asher