Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add deprecation notice for --link #4562

Merged
merged 2 commits into from
Nov 29, 2021
Merged

chore: add deprecation notice for --link #4562

merged 2 commits into from
Nov 29, 2021

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Nov 29, 2021

code-server --link has not been updated for a while, and some users have reported connection issues with it (see #2734)

While we will continue to host the --link servers, this PR adds a warning that we are not officially maintaining this version of --link. In the future, we will likely release an improved version, using a new architecture and codebase. However, there is no timeline for this.

@bpmct bpmct requested a review from jsjoeio November 29, 2021 04:15
@bpmct bpmct requested a review from a team as a code owner November 29, 2021 04:15
@github-actions
Copy link

github-actions bot commented Nov 29, 2021

✨ Coder.com for PR #4562 deployed! It will be updated on every commit.

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #4562 (9ad76d7) into main (3d46604) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4562   +/-   ##
=======================================
  Coverage   65.44%   65.44%           
=======================================
  Files          30       30           
  Lines        1664     1664           
  Branches      335      335           
=======================================
  Hits         1089     1089           
  Misses        487      487           
  Partials       88       88           
Impacted Files Coverage Δ
src/node/cli.ts 80.62% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d46604...9ad76d7. Read the comment docs.

@bpmct bpmct self-assigned this Nov 29, 2021
@bpmct bpmct added chore Related to maintenance or clean up docs Documentation related labels Nov 29, 2021
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on @bpmct! 🙌

@bpmct bpmct merged commit 6a2740f into main Nov 29, 2021
@bpmct bpmct deleted the bpmct/depricate-link branch November 29, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants