Escape HTML from messages in error page

[mauri]

Fixes #4355

Escapes HTML contained in error messages before rendering the error page.

[codecov]

Codecov Report

Merging #4430 (704525b) into main (605c3c6) will increase coverage by 0.37%.
The diff coverage is 100.00%.

❗ Current head 704525b differs from pull request most recent head 7a6dc3e. Consider uploading reports for the commit 7a6dc3e to get more accurate results

@@            Coverage Diff             @@
##             main    #4430      +/-   ##
==========================================
+ Coverage   66.04%   66.41%   +0.37%     
==========================================
  Files          30       30              
  Lines        1602     1602              
  Branches      315      315              
==========================================
+ Hits         1058     1064       +6     
+ Misses        466      461       -5     
+ Partials       78       77       -1     

Impacted Files	Coverage Δ
src/node/routes/errors.ts	91.30% <100.00%> (+21.73%)	⬆️
src/node/util.ts	79.78% <0.00%> (+0.54%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 605c3c6...7a6dc3e. Read the comment docs.

[jsjoeio]

WOW! Not only did you fix this, but you added tests! This has to be a first (at least in a while) 🎉

[jsjoeio]

Thanks so much for adding this and writing tests!

[jsjoeio]

Bummer we have to do this but I don't see any better alternatives

[jsjoeio]

The Docs preview is broken on forks at the moment but as long as everything else passes (it should), then we can merge!

[mauri]

Looks like E2E tests are failing to run, showing Try re-installing playwright with "npm install playwright"

[jsjoeio]

Looks like E2E tests are failing to run, showing

Classic. Probably a yarn issue. Sorry about that. @code-asher and I will see if we can fix this.

[jsjoeio]

Do you mind rebasing onto main and pushing up? (I don't think maintainers can edit)

We pushed a fix for playwright so hopefully everything works 🤞

[mauri]

@jsjoeio rebased onto main branch 👍

[jsjoeio]

There's a high chance this doesn't work (e2e tests are failing on other PRs for some odd reason). We think this might fix but we'll see. So sorry for all the CI trouble!

[mauri]

@jsjoeio is there anything else I should do?

[jsjoeio]

@mauri thanks for the ping! Looks like @code-asher updated your branch. Once CI finishes, we should be good to merge!

[jsjoeio]

Not sure why macOS build is failing. Cancelling and re-running