Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolving error of nodejs #4336

Merged
merged 2 commits into from
Oct 25, 2021
Merged

resolving error of nodejs #4336

merged 2 commits into from
Oct 25, 2021

Conversation

mrfoxie
Copy link
Contributor

@mrfoxie mrfoxie commented Oct 11, 2021

to be on save side while installing code-server using yarn on Termux to prevent the following error

yarn global add code-server
yarn global v1.22.15
[1/4] Resolving packages...
[2/4] Fetching packages... 
error code-server@3.12.0: The engine "node" is incompatible with this module. Expected version "= 14". Got "16.11.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/global for documentation about this command.

Fixes #

to be on save side while installing code-server using yarn on Termux to prevent the following error
```
yarn global add code-server
yarn global v1.22.15
[1/4] Resolving packages...
[2/4] Fetching packages... 
error code-server@3.12.0: The engine "node" is incompatible with this module. Expected version "= 14". Got "16.11.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/global for documentation about this command.
```
@mrfoxie mrfoxie requested a review from a team as a code owner October 11, 2021 12:25
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

@jsjoeio jsjoeio self-assigned this Oct 11, 2021
@jsjoeio jsjoeio added the docs Documentation related label Oct 11, 2021
@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #4336 (0def1e3) into main (271bc06) will not change coverage.
The diff coverage is n/a.

❗ Current head 0def1e3 differs from pull request most recent head 967832d. Consider uploading reports for the commit 967832d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4336   +/-   ##
=======================================
  Coverage   68.22%   68.22%           
=======================================
  Files          31       31           
  Lines        1586     1586           
  Branches      308      308           
=======================================
  Hits         1082     1082           
  Misses        430      430           
  Partials       74       74           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 271bc06...967832d. Read the comment docs.

@mrfoxie mrfoxie closed this Oct 13, 2021
@mrfoxie mrfoxie reopened this Oct 13, 2021
Since we are installing nodejs-lts.  I am not even sure it lets you install both anyway.
@code-asher code-asher self-requested a review October 25, 2021 16:13
@code-asher code-asher merged commit 0e97a94 into coder:main Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants