Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update collaboration.md #4281

Merged
merged 2 commits into from
Sep 30, 2021
Merged

Update collaboration.md #4281

merged 2 commits into from
Sep 30, 2021

Conversation

toddewilliams
Copy link
Contributor

I updated the CodeTogether description to include some enhancements that we just shipped in CodeTogether 4.2. I also added a bit more detail to the feature list and provided some hyperlinks in a couple of places where people would likely appreciate more detail.

I made no changes to the other sections.

Fixes #4280

I updated the CodeTogether description to include some enhancements that we just shipped in CodeTogether 4.2. I also added a bit more detail to the feature list and provided some hyperlinks in a couple of places where people would likely appreciate more detail. 

I made no changes to the other sections.
@toddewilliams toddewilliams requested a review from a team as a code owner September 30, 2021 17:08
Copy link
Contributor

@GirlBossRush GirlBossRush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for sending these changes over.

Much appreciated ✨

@GirlBossRush GirlBossRush enabled auto-merge (rebase) September 30, 2021 19:07
@toddewilliams
Copy link
Contributor Author

Glad to contribute! But the build seems to have failed. Anything for me to do here?

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 30, 2021

@toddewilliams

Is it possible for you to run yarn fmt locally? Otherwise, if you checked the box "allow edits from maintainers" then I can do it for you. Just let me know!

image

@toddewilliams
Copy link
Contributor Author

Fortunately, I did check the box to allow edits from maintainers because it's your project and that only seems right.

So I'd greatly appreciate it if you'd do the needful to push this on through Joe. My days of being in git every day are behind me at this point. Thanks in advance!

@jsjoeio jsjoeio self-assigned this Sep 30, 2021
@jsjoeio jsjoeio added the docs Documentation related label Sep 30, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 30, 2021

Fortunately, I did check the box to allow edits from maintainers because it's your project and that only seems right.

Awesome! (No way for me to know sadly without asking)

Let me see if I can push changes to get this fixed

@jsjoeio jsjoeio disabled auto-merge September 30, 2021 22:08
@jsjoeio jsjoeio enabled auto-merge (squash) September 30, 2021 22:24
@jsjoeio jsjoeio disabled auto-merge September 30, 2021 22:24
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #4281 (a14fa86) into main (6eda7ae) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4281   +/-   ##
=======================================
  Coverage   65.32%   65.32%           
=======================================
  Files          36       36           
  Lines        1883     1883           
  Branches      380      380           
=======================================
  Hits         1230     1230           
  Misses        555      555           
  Partials       98       98           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eda7ae...a14fa86. Read the comment docs.

@jsjoeio jsjoeio merged commit 48ce49e into coder:main Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeTogether section in Collaboration.md needs to be updated
3 participants