Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move default PR template #3375

Merged
merged 1 commit into from
May 14, 2021
Merged

refactor: move default PR template #3375

merged 1 commit into from
May 14, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented May 12, 2021

This PR fixes the default PR template.

To set the default, we must follow this structure:

.github
    -> PULL_REQUEST_TEMPLATE.md (This going to be the default one)
    -> PULL_REQUEST_TEMPLATE (folder)
        -> custom1 
        -> custom2

source: https://github.uint.cloudmunity/t/multiple-pull-request-template/874/10

Checklist

  • updated CHANGELOG.md

@jsjoeio jsjoeio self-assigned this May 12, 2021
@jsjoeio jsjoeio added this to the v3.11.0 milestone May 12, 2021
@jsjoeio jsjoeio added the docs Documentation related label May 12, 2021
@jsjoeio jsjoeio force-pushed the jsjoeio/fix-pr-template branch from 3b672d6 to d6cec51 Compare May 12, 2021 21:42
@jsjoeio jsjoeio marked this pull request as ready for review May 12, 2021 21:42
@jsjoeio jsjoeio requested a review from a team as a code owner May 12, 2021 21:42
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #3375 (7a3936d) into main (b49b179) will not change coverage.
The diff coverage is n/a.

❗ Current head 7a3936d differs from pull request most recent head 6f09749. Consider uploading reports for the commit 6f09749 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3375   +/-   ##
=======================================
  Coverage   59.21%   59.21%           
=======================================
  Files          35       35           
  Lines        1709     1709           
  Branches      379      379           
=======================================
  Hits         1012     1012           
  Misses        559      559           
  Partials      138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b49b179...6f09749. Read the comment docs.

@jsjoeio jsjoeio force-pushed the jsjoeio/fix-pr-template branch from d6cec51 to 4d1dd3e Compare May 12, 2021 21:51
@jsjoeio jsjoeio force-pushed the jsjoeio/fix-pr-template branch from 4d1dd3e to 6f09749 Compare May 14, 2021 20:18
@jsjoeio jsjoeio enabled auto-merge May 14, 2021 20:18
@jsjoeio jsjoeio merged commit a7cf990 into main May 14, 2021
@jsjoeio jsjoeio deleted the jsjoeio/fix-pr-template branch May 14, 2021 20:22
@coder coder deleted a comment from orvice May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants