This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danke für den Pull-Request! Ein paar Verbesserungsvorschläge / Anmerkungen vor dem Merge:
Das war der erste Blick, ansonsten eine gute Erweiterung! [1] https://docs.oracle.com/javase/tutorial/2d/images/saveimage.html |
Hi. Es fehlt soweit nur noch der 2. Punkt (und evtl. weitere Verbesserungen von deiner/eurer Seite). Den Konflikt werde ich nachdem beheben, sobald das Problem mit @joblo2213 soweit behoben worden ist. |
Hi. Soweit sollte alles dabei sein. Hab folgende Sachen getestet:
|
sebinside
reviewed
Jun 11, 2019
src/main/scala/org/codeoverflow/chatoverflow/requirement/service/file/FileConnector.scala
Outdated
Show resolved
Hide resolved
sebinside
reviewed
Jun 11, 2019
src/main/scala/org/codeoverflow/chatoverflow/requirement/service/file/FileConnector.scala
Outdated
Show resolved
Hide resolved
Well done! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added basic file i/o.
Current functions: