Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

English fix #5

Merged
merged 25 commits into from
Aug 11, 2019
Merged

English fix #5

merged 25 commits into from
Aug 11, 2019

Conversation

andi-makes
Copy link
Contributor

@andi-makes andi-makes commented Jul 27, 2019

Fixed/Improved English in Files:

  • Home.md
  • _Footer.md
  • usage/Installation.md

Todo:

  • usage/Frequent-Issues.md
  • usage/Using-the-CLI.md
  • usage/Using-the-GUI.md

Feedback is highly appreciated!

usage/Installation.md Outdated Show resolved Hide resolved
@J0B10
Copy link
Member

J0B10 commented Jul 27, 2019

It's looking good till now. Ignore my comment on the Installation.md.

We'll propably completly redo the Installation.md to match with the new install scripts from codeoverflow-org/chatoverflow#63

@andi-makes andi-makes marked this pull request as ready for review July 31, 2019 17:52
@andi-makes
Copy link
Contributor Author

I have decided to only change the files in the usage Folder as well as in the root folder, because I have been struggeling with merging the new changes from master into this pull request.

I will edit the other pages using the pen, I think this will spare me some headaches 😄

I've also fixed typos in the new Installation.md. I also made changes to the structure of the file, if there is a need to change it back I of course will do it.

As always, feedback is highly appreciated!

@hlxid hlxid self-requested a review July 31, 2019 18:13
DragonCoder01 added 7 commits July 31, 2019 21:32
development/Setting-up-the-Build-Environment.md
development/Adding-a-new-platform-source.md
development/Deploy-ChatOverflow.md
development/Writing-a-plugin.md
services/Discord.md
services/Serial.md
services/Twitch-Chat.md
@andi-makes
Copy link
Contributor Author

Well, now I have sacrificed my evening with quickly going through all the other files in the wiki thanks to MelanXs message in the Discord channel. All the obvious typos should be gone now, but of course there could be some spelling/grammar wrong.

If there is anything I've missed, let me know, because you know, feedback is highly appreciated!

Copy link
Member

@hlxid hlxid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me for the most part (see my comments down below), but because my English isn't that good either I think @joblo2213 should still take a look.

Many thanks for this pr in advance 😃 !

development/Writing-a-plugin.md Outdated Show resolved Hide resolved
development/Writing-a-plugin.md Outdated Show resolved Hide resolved
usage/Using-the-GUI.md Outdated Show resolved Hide resolved
usage/Using-the-CLI.md Outdated Show resolved Hide resolved
Andreas and others added 4 commits August 1, 2019 10:01
Co-Authored-By: Daniel Huber <daniel.hub@outlook.de>
Co-Authored-By: Daniel Huber <daniel.hub@outlook.de>
Added some suggestion from daniel0611.
Co-Authored-By: Daniel Huber <daniel.hub@outlook.de>
Copy link

@justgerd justgerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the gigantic wall of requested changes here, most of them are probably just nitpicks. I have a feeling that I'll have to read through the whole docs at some point to find even more small and insignificant mistakes and make another PR out of it.

development/Adding-a-new-platform-source.md Outdated Show resolved Hide resolved
development/Adding-a-new-platform-source.md Outdated Show resolved Hide resolved
development/Deploy-ChatOverflow.md Outdated Show resolved Hide resolved
development/Writing-a-plugin.md Outdated Show resolved Hide resolved
development/Writing-a-plugin.md Outdated Show resolved Hide resolved
usage/Installation.md Outdated Show resolved Hide resolved
usage/Using-the-GUI.md Outdated Show resolved Hide resolved
usage/Using-the-GUI.md Outdated Show resolved Hide resolved
usage/Using-the-GUI.md Outdated Show resolved Hide resolved
usage/Using-the-GUI.md Outdated Show resolved Hide resolved
@J0B10
Copy link
Member

J0B10 commented Aug 3, 2019

It's getting better and better, thanks for all your contribution 😄 👍

DragonCoder01 added 3 commits August 3, 2019 11:16
Line 3 in development/Adding-a-new-platform-source.md.
A imporvement for it will be in the next commit.
As well as a small change in Using-the-Gui.md
Added name of the root module
@J0B10 J0B10 merged commit 4109c8d into codeoverflow-org:master Aug 11, 2019
J0B10 added a commit that referenced this pull request Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants