-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
It's looking good till now. Ignore my comment on the Installation.md. We'll propably completly redo the Installation.md to match with the new install scripts from codeoverflow-org/chatoverflow#63 |
I have decided to only change the files in the usage Folder as well as in the root folder, because I have been struggeling with merging the new changes from master into this pull request. I will edit the other pages using the pen, I think this will spare me some headaches 😄 I've also fixed typos in the new Installation.md. I also made changes to the structure of the file, if there is a need to change it back I of course will do it. As always, feedback is highly appreciated! |
development/Setting-up-the-Build-Environment.md
development/Adding-a-new-platform-source.md
development/Deploy-ChatOverflow.md
development/Writing-a-plugin.md
services/Discord.md
services/Serial.md
services/Twitch-Chat.md
Well, now I have sacrificed my evening with quickly going through all the other files in the wiki thanks to MelanXs message in the Discord channel. All the obvious typos should be gone now, but of course there could be some spelling/grammar wrong. If there is anything I've missed, let me know, because you know, feedback is highly appreciated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me for the most part (see my comments down below), but because my English isn't that good either I think @joblo2213 should still take a look.
Many thanks for this pr in advance 😃 !
Co-Authored-By: Daniel Huber <daniel.hub@outlook.de>
Co-Authored-By: Daniel Huber <daniel.hub@outlook.de>
Added some suggestion from daniel0611.
Co-Authored-By: Daniel Huber <daniel.hub@outlook.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the gigantic wall of requested changes here, most of them are probably just nitpicks. I have a feeling that I'll have to read through the whole docs at some point to find even more small and insignificant mistakes and make another PR out of it.
It's getting better and better, thanks for all your contribution 😄 👍 |
Line 3 in development/Adding-a-new-platform-source.md. A imporvement for it will be in the next commit.
As well as a small change in Using-the-Gui.md
Added name of the root module
Fixed/Improved English in Files:
Todo:
Feedback is highly appreciated!