This repository has been archived by the owner on May 9, 2020. It is now read-only.
Remove a few problematic TLSv1.0 ciphers #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will take a look today. Sorry, I'm traveling now and have a very limited
internet access :)
…On Wed, May 22, 2019, 06:51 Dwayne ***@***.***> wrote:
@pro-src <https://github.com/pro-src> requested your review on: #219
<#219> Remove a few
problematic TLSv1.0 ciphers.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#219?email_source=notifications&email_token=AACK6QD5BOZP5G7CJCI3YU3PWR4FPA5CNFSM4HM4R4AKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGORSDQXOA#event-2357660600>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACK6QBA4QEKML6ABCL2R2TPWR4FPANCNFSM4HM4R4AA>
.
|
|
Thanks :) |
codemanki
reviewed
May 22, 2019
codemanki
approved these changes
May 22, 2019
|
Awesome! Thank you :) Merging and releasing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the same problem as #212 but without adding TLSv1.3 options for older openssl versions. As noted in this #211 (comment) , the TLSv1.3 options aren't the actual reason why #212 resolved the problem for the OP.
This is a minimal solution and is known to avoid the CAPTCHA on the latest version of openssl as well as older versions. It is reproducible on Node.js v10.8.0 which uses openssl v1.1.0h
Fixes #211