Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Match profile type and cert for MAC_APP_DIRECT #246

Merged
merged 5 commits into from
Jul 18, 2022

Conversation

VeArnold
Copy link
Contributor

@VeArnold VeArnold commented Jul 18, 2022

Currently, setting the parameter --type to MAC_APP_DIRECT when using app-store-connect fetch-signing-files results in the following error:

Traceback (most recent call last):
  File "/Users/builder/.pyenv/versions/3.8.7/lib/python3.8/site-packages/codemagic/cli/cli_app.py", line 202, in invoke_cli
    CliApp._running_app._invoke_action(args)
  File "/Users/builder/.pyenv/versions/3.8.7/lib/python3.8/site-packages/codemagic/cli/cli_app.py", line 158, in _invoke_action
    return cli_action(**action_args)
  File "/Users/builder/.pyenv/versions/3.8.7/lib/python3.8/site-packages/codemagic/cli/cli_app.py", line 417, in wrapper
    return func(*args, **kwargs)
  File "/Users/builder/.pyenv/versions/3.8.7/lib/python3.8/site-packages/codemagic/tools/app_store_connect.py", line 756, in fetch_signing_files
    certificates = self._get_or_create_certificates(
  File "/Users/builder/.pyenv/versions/3.8.7/lib/python3.8/site-packages/codemagic/tools/app_store_connect.py", line 802, in _get_or_create_certificates
    certificate_types = [CertificateType.from_profile_type(profile_type)]
  File "/Users/builder/.pyenv/versions/3.8.7/lib/python3.8/site-packages/codemagic/apple/resources/enums.py", line 135, in from_profile_type
    raise ValueError(f'Certificate type for profile type {profile_type} is unknown')
ValueError: Certificate type for profile type MAC_APP_DIRECT is unknown

This PR proposes to set the certificate type to DEVELOPER_ID_APPLICATION when the profile type is MAC_APP_DIRECT.

Similar matching to what is proposed in this PR can be found in this Fastlane PR on line 254.

Updated actions:

  • app-store-connect fetch-signing-files

@VeArnold VeArnold changed the title WIP: Match profile type and cert for MAC_APP_DIRECT Bugfix: Match profile type and cert for MAC_APP_DIRECT Jul 18, 2022
@priitlatt priitlatt self-requested a review July 18, 2022 07:15
@VeArnold VeArnold merged commit a683d84 into master Jul 18, 2022
@VeArnold VeArnold deleted the fix/match-mac-app-direct-profile branch July 18, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants