Improvement: xcresult test result parsing speedup
#223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashant-bhargava-hs
approved these changes
May 11, 2022
artemii-yanushevskyi
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case Xcode project has a lot of tests, then parsing test result information from generated
xcresultbundle can become relatively slow. This is because underlying conversion commandto transform binary test results included in the bundle to
JSONformat can generate a lot of output (30+ MB at 500K+ lines).Evidently processing this kind of text output in Python via small (8KB) chunks is not the most efficient way to deal with it. As the output is only needed as a whole once the command is completed, then it makes sense to pipe it directly to a file, and finally read the generated JSON from this file once processing is completed.
Updated actions
xcode-project run-testsxcode-project junit-test-resultsxcode-project test-summary