Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add action to extract certificates infomation from keystore #213

Merged
merged 5 commits into from
Mar 28, 2022

Conversation

priitlatt
Copy link
Contributor

@priitlatt priitlatt commented Mar 25, 2022

This PR included changes and improvements to both command line and Python API for extracting information from Android keystores.

Breaking changes

  • CLI: Remove key password option (specified by -l, --ks-key-pass or --key-pass) from android-keystore verify action as it is not used.
  • Python API: Remove key_password keyword argument from AndroidKeystore.verify.
  • Python API: Change signature of Keytool.validate_keystore. Required arguments are now keystore_path: pathlib.Path, keystore_password: str and key_alias: str instead of single keystore: Keystore.

New CLI actions

android-keystore certificates to list information about certificates included in the keystore.

Example usage of 'android-keystore certificates'

@priitlatt priitlatt marked this pull request as ready for review March 28, 2022 08:15
@priitlatt priitlatt added the enhancement New feature or request label Mar 28, 2022
@priitlatt priitlatt merged commit 299e286 into master Mar 28, 2022
@priitlatt priitlatt deleted the feature/keystore-info branch March 28, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants