Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation: Ignore --skip-package-validation option for app-store-connect publish #174

Merged
merged 4 commits into from
Dec 20, 2021

Conversation

priitlatt
Copy link
Contributor

@priitlatt priitlatt commented Dec 20, 2021

Oftentimes, when submitting application package to App Store Connect via app-store-connect publish, the package validation command, which is invoked by running

xcrun altool --validate-app --file /path/to/app.ipa ...

fails due to

  • Apple services being unavailable,
  • Apple is not capable of validating the package because of "Unable to process app at this time due to a general error",
  • vague authentication failure.

And all this happens despite the fact that actually the very same binary can be uploaded just fine in case validation is disabled.

In order to avoid such false alarms about validation failures, disable package validation by default (previously it was enabled by default), and leave option to turn in on by using a CLI option --enable-package-validation.

Updated actions:

  • app-store-connect publish

Notable changes:

  • Deprecate --skip-package-validation option for app-store-connect publish.
  • App new option --enable-package-validation option for `app-store-connect publish.
  • Show a deprecation warning in case --skip-package-validation was used.

@priitlatt priitlatt changed the title Deprecation: Ignore --skip-package-validation option for app-store-connect publish Deprecation: Ignore --skip-package-validation option for app-store-connect publish Dec 20, 2021
Update expected default behaviour for app-store-connect publish
with respect changed package validation logic.
@priitlatt priitlatt marked this pull request as ready for review December 20, 2021 10:51
@priitlatt priitlatt merged commit 315aa14 into master Dec 20, 2021
@priitlatt priitlatt deleted the feature/skip-package-validation-by-default branch December 20, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants