Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Fix phpstan nullCoalesce #9374

Merged
merged 1 commit into from
Jan 8, 2025
Merged

refactor: Fix phpstan nullCoalesce #9374

merged 1 commit into from
Jan 8, 2025

Conversation

neznaika0
Copy link
Contributor

Description
A couple of fixes. Added a RouteCollection type for IDE hints.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

samsonasik
samsonasik reviewed Jan 5, 2025
View reviewed changes
system/Router/Router.php Outdated Show resolved Hide resolved
@neznaika0 neznaika0 force-pushed the refactor/phpstan-nullCoalesce branch from a6e76e2 to 6d04e1d Compare January 7, 2025 20:23
@neznaika0 neznaika0 requested a review from samsonasik January 7, 2025 20:27
@samsonasik samsonasik requested review from kenjis and michalsn January 8, 2025 01:50
@samsonasik samsonasik merged commit dd08f95 into codeigniter4:develop Jan 8, 2025
41 checks passed
@samsonasik
Copy link
Member

Thank you @neznaika0

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Jan 8, 2025
@neznaika0 neznaika0 deleted the refactor/phpstan-nullCoalesce branch January 8, 2025 08:53
@neznaika0 neznaika0 mentioned this pull request Jan 8, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@samsonasik samsonasik samsonasik approved these changes

@kenjis kenjis Awaiting requested review from kenjis

@michalsn michalsn Awaiting requested review from michalsn

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neznaika0 @samsonasik @paulbalandan