Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use compare empty array on Forge on keys property #9267

Merged
merged 1 commit into from
Nov 12, 2024
Merged

refactor: use compare empty array on Forge on keys property #9267

merged 1 commit into from
Nov 12, 2024

Conversation

samsonasik
Copy link
Member

Description

The usage of keys property is as array, eg: count($this->key) so compare with empty array is fine, other check also compare with empty array.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Member Author

Ready to merge 👍

@samsonasik samsonasik mentioned this pull request Nov 12, 2024
Merged
@samsonasik samsonasik requested a review from michalsn November 12, 2024 02:56
@samsonasik
Copy link
Member Author

Thank you @paulbalandan for the review, let's merge ;)

@samsonasik samsonasik merged commit 1e9483c into codeigniter4:develop Nov 12, 2024
41 checks passed
@samsonasik samsonasik deleted the use-compare-empty-array branch November 12, 2024 04:01
@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@kenjis kenjis Awaiting requested review from kenjis

@MGatner MGatner Awaiting requested review from MGatner

@michalsn michalsn Awaiting requested review from michalsn

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @paulbalandan