Change current_url() to use cloned URI #2420
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Presently
current_url()
returns a reference to the shared Request service's URI property, making it possible to use the returned object to modify the global Request object to undesirable effect.This PR makes
current_url()
return a cloned version of the URI object so it can be manipulated freely. One word - I added one word for a bug that took over an hour to track down. ONE. WORD.Checklist: